Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP Docs #26509

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Update PHP Docs #26509

merged 3 commits into from
Feb 7, 2020

Conversation

orozcodiaz
Copy link
Contributor

Update PHP Docs for certain functions in Magento/Store/Model/Config/Importer/Processor/Create.php

@m2-assistant
Copy link

m2-assistant bot commented Jan 23, 2020

Hi @oroskodias. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2020
@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2020
@rogyar rogyar self-assigned this Jan 24, 2020
@rogyar rogyar added Cleanup Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6679 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jan 24, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Golf engcom-Golf self-assigned this Jan 24, 2020
@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 24, 2020
@magento-engcom-team magento-engcom-team added Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 27, 2020
@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020
@slavvka
ENGCOM-6679: Update PHP Docs #26509
64fb41b
@magento-engcom-team magento-engcom-team merged commit 5b0c097 into magento:2.4-develop Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @oroskodias, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@shiftedreality shiftedreality Awaiting requested review from shiftedreality

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@rogyar rogyar

@VladimirZaets VladimirZaets

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Store Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@orozcodiaz @magento-engcom-team @engcom-Delta @rogyar @VladimirZaets @engcom-Golf